Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1407413011: Removing AtomicReference using ThreadUtils (Closed)

Created:
5 years, 1 month ago by AKV
Modified:
5 years, 1 month ago
Reviewers:
Ted C, boliu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing AtomicReference using ThreadUtils This change takes care of removing AtomicReference using ThreadUtils package. BUG= Committed: https://crrev.com/8575b7adb147aead0f767e33c82f4a503ab7285c Cr-Commit-Position: refs/heads/master@{#357800}

Patch Set 1 #

Patch Set 2 : Fixed the test cases breaks. #

Patch Set 3 : Removing AtomicReference from few more classes. #

Total comments: 6

Patch Set 4 : Addressed review comments and fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -33 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 1 2 3 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivityTest.java View 1 2 3 3 chunks +12 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java View 1 2 3 3 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
AKV
PTAL!
5 years, 1 month ago (2015-10-30 16:42:53 UTC) #2
AKV
PTAL!
5 years, 1 month ago (2015-11-03 16:31:14 UTC) #4
boliu
lgtm https://codereview.chromium.org/1407413011/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java File android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java (right): https://codereview.chromium.org/1407413011/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java#newcode420 android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:420: final AwContentsClient client, final boolean supportsLegacyQuirks) throws Exception ...
5 years, 1 month ago (2015-11-03 17:02:30 UTC) #5
Ted C
lgtm w/ a couple style nits https://codereview.chromium.org/1407413011/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivityTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivityTest.java (right): https://codereview.chromium.org/1407413011/diff/40001/chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivityTest.java#newcode75 chrome/android/javatests/src/org/chromium/chrome/browser/bookmark/ManageBookmarkActivityTest.java:75: @Override this block ...
5 years, 1 month ago (2015-11-03 17:53:08 UTC) #6
AKV
Fixed all comments. Thank you for review. https://codereview.chromium.org/1407413011/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java File android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java (right): https://codereview.chromium.org/1407413011/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java#newcode420 android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:420: final AwContentsClient ...
5 years, 1 month ago (2015-11-04 10:54:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407413011/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407413011/60001
5 years, 1 month ago (2015-11-04 10:55:07 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-04 11:32:44 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 11:33:42 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8575b7adb147aead0f767e33c82f4a503ab7285c
Cr-Commit-Position: refs/heads/master@{#357800}

Powered by Google App Engine
This is Rietveld 408576698