Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1407393009: Stage --harmony-destructuring and --harmony-default-parameters (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, rossberg, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage --harmony-destructuring and --harmony-default-parameters Since enabling destructuring already implies enabling default parameters, there's not a good way to separate these two. Luckily, they're both feature-complete (save for destructuring assignment). This causes us to pass an additional 24 test262 tests. BUG=v8:811, v8:2160 LOG=y Committed: https://crrev.com/2a866bc4dd6318692aee0ea45b20da3f1c0a5420 Cr-Commit-Position: refs/heads/master@{#31844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test262/test262.status View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
adamk
5 years, 1 month ago (2015-11-05 21:18:01 UTC) #3
Dan Ehrenberg
lgtm
5 years, 1 month ago (2015-11-05 21:19:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407393009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407393009/1
5 years, 1 month ago (2015-11-05 21:20:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 21:40:06 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 21:40:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a866bc4dd6318692aee0ea45b20da3f1c0a5420
Cr-Commit-Position: refs/heads/master@{#31844}

Powered by Google App Engine
This is Rietveld 408576698