runtime/vm/object_test.cc - Issue 1407393005: Get tools/test.py --noopt green.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_test.cc

Issue 1407393005: Get tools/test.py --noopt green. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object_test.cc

diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc

index e186ea063d1a7e469339f7f0773974b2163dc51c..b8bd8ff5aa7c1a2d798fcb0ea108ec9d6bdde9a9 100644

--- a/runtime/vm/object_test.cc

+++ b/runtime/vm/object_test.cc

@@ -2783,7 +2783,7 @@ TEST_CASE(EmbedSmiInCode) {

// Test for Embedded Smi object in the instructions.

TEST_CASE(EmbedSmiIn64BitCode) {

extern void GenerateEmbedSmiInCode(Assembler* assembler, intptr_t value);

- const intptr_t kSmiTestValue = 5L << 32;

+ const intptr_t kSmiTestValue = DART_INT64_C(5) << 32;

Assembler _assembler_;

GenerateEmbedSmiInCode(&_assembler_, kSmiTestValue);

const Function& function =