Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 1407393002: ImageBitmap: Change two enum uses. (Closed) Base URL:
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index cae4fbb1b70f014d4cf0cef8c7a2c51a84d7ff7d..5425fa0b59d2318dbfa060c431ca660f51961001 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -98,7 +98,7 @@ ImageBitmap::ImageBitmap(ImageData* data, const IntRect& cropRect)
, m_bitmapOffset(IntPoint())
IntRect srcRect = intersection(cropRect, IntRect(IntPoint(), data->size()));
- OwnPtr<ImageBuffer> buffer = ImageBuffer::create(data->size(), Opaque, DoNotInitializeImagePixels);
+ OwnPtr<ImageBuffer> buffer = ImageBuffer::create(data->size(), NonOpaque, DoNotInitializeImagePixels);
xidachen 2015/10/18 14:08:48 This part is tricky. It was set to be Opaque on pu
jbroman 2015/10/18 15:44:14 I'd like Justin's opinion, but it seems to me that
xidachen 2015/10/18 15:44:52 Hmmm, I just found something very strange. With th
jbroman 2015/10/18 15:48:00 Yeah, something fishy is going on (or I'm misunder
Justin Novosad 2015/10/19 19:13:20 I agree that the image buffer should be marked as
if (!buffer)

Powered by Google App Engine
This is Rietveld 408576698