Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: src/code-factory.cc

Issue 1407373007: Remove CallFunctionStub, always call through the Call builtin (also from CallIC) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-factory.cc
diff --git a/src/code-factory.cc b/src/code-factory.cc
index e451b0467632bbc2612e55dd01d59ec5a867e744..e168b9d20cbe082d21fa482239c8a6d7da752dee 100644
--- a/src/code-factory.cc
+++ b/src/code-factory.cc
@@ -58,19 +58,16 @@ Callable CodeFactory::KeyedLoadICInOptimizedCode(
// static
-Callable CodeFactory::CallIC(Isolate* isolate, int argc,
- CallICState::CallType call_type) {
- return Callable(CallIC::initialize_stub(isolate, argc, call_type),
+Callable CodeFactory::CallIC(Isolate* isolate, int argc) {
+ return Callable(CallIC::initialize_stub(isolate, argc),
CallFunctionWithFeedbackDescriptor(isolate));
}
// static
-Callable CodeFactory::CallICInOptimizedCode(Isolate* isolate, int argc,
- CallICState::CallType call_type) {
- return Callable(
- CallIC::initialize_stub_in_optimized_code(isolate, argc, call_type),
- CallFunctionWithFeedbackAndVectorDescriptor(isolate));
+Callable CodeFactory::CallICInOptimizedCode(Isolate* isolate, int argc) {
+ return Callable(CallIC::initialize_stub_in_optimized_code(isolate, argc),
+ CallFunctionWithFeedbackAndVectorDescriptor(isolate));
}
@@ -288,14 +285,6 @@ Callable CodeFactory::AllocateInNewSpace(Isolate* isolate) {
// static
-Callable CodeFactory::CallFunction(Isolate* isolate, int argc,
- CallFunctionFlags flags) {
- CallFunctionStub stub(isolate, argc, flags);
- return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
-}
-
-
-// static
Callable CodeFactory::ArgumentAdaptor(Isolate* isolate) {
return Callable(isolate->builtins()->ArgumentsAdaptorTrampoline(),
ArgumentAdaptorDescriptor(isolate));
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698