Remove CallFunctionStub, always call through the Call builtin (also from CallIC)

src/code-factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-factory.h"
 
 #include "src/bootstrapper.h"
 #include "src/ic/ic.h"
 
 namespace v8 {
@@ skipping 40 matching lines @@
   auto code = KeyedLoadIC::initialize_stub_in_optimized_code(
       isolate, initialization_state, state);
   if (initialization_state != MEGAMORPHIC) {
     return Callable(code, LoadWithVectorDescriptor(isolate));
   }
   return Callable(code, LoadDescriptor(isolate));
 }
 
 
 // static
-Callable CodeFactory::CallIC(Isolate* isolate, int argc,
-                             CallICState::CallType call_type) {
-  return Callable(CallIC::initialize_stub(isolate, argc, call_type),
+Callable CodeFactory::CallIC(Isolate* isolate, int argc) {
+  return Callable(CallIC::initialize_stub(isolate, argc),
                   CallFunctionWithFeedbackDescriptor(isolate));
 }
 
 
 // static
-Callable CodeFactory::CallICInOptimizedCode(Isolate* isolate, int argc,
-                                            CallICState::CallType call_type) {
-  return Callable(
-      CallIC::initialize_stub_in_optimized_code(isolate, argc, call_type),
-      CallFunctionWithFeedbackAndVectorDescriptor(isolate));
+Callable CodeFactory::CallICInOptimizedCode(Isolate* isolate, int argc) {
+  return Callable(CallIC::initialize_stub_in_optimized_code(isolate, argc),
+                  CallFunctionWithFeedbackAndVectorDescriptor(isolate));
 }
 
 
 // static
 Callable CodeFactory::StoreIC(Isolate* isolate, LanguageMode language_mode) {
   return Callable(
       StoreIC::initialize_stub(isolate, language_mode, UNINITIALIZED),
       FLAG_vector_stores ? VectorStoreICTrampolineDescriptor(isolate)
                          : StoreDescriptor(isolate));
 }
@@ skipping 197 matching lines @@
 
 
 // static
 Callable CodeFactory::AllocateInNewSpace(Isolate* isolate) {
   AllocateInNewSpaceStub stub(isolate);
   return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
 }
 
 
 // static
-Callable CodeFactory::CallFunction(Isolate* isolate, int argc,
-                                   CallFunctionFlags flags) {
-  CallFunctionStub stub(isolate, argc, flags);
-  return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
-}
-
-
-// static
 Callable CodeFactory::ArgumentAdaptor(Isolate* isolate) {
   return Callable(isolate->builtins()->ArgumentsAdaptorTrampoline(),
                   ArgumentAdaptorDescriptor(isolate));
 }
 
 
 // static
 Callable CodeFactory::Call(Isolate* isolate) {
   return Callable(isolate->builtins()->Call(),
                   CallTrampolineDescriptor(isolate));
@@ skipping 18 matching lines @@
 Callable CodeFactory::InterpreterCEntry(Isolate* isolate) {
   // TODO(rmcilroy): Deal with runtime functions that return two values.
   // Note: If we ever use fpregs in the interpreter then we will need to
   // save fpregs too.
   CEntryStub stub(isolate, 1, kDontSaveFPRegs, kArgvInRegister);
   return Callable(stub.GetCode(), InterpreterCEntryDescriptor(isolate));
 }
 
 }  // namespace internal
 }  // namespace v8