chrome/browser/ui/webui/engagement/site_engagement_ui.cc - Issue 1407363010: Make table in chrome:site-engagement sortable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/engagement/site_engagement_ui.cc

diff --git a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc

index 64cc553338f12254860cc3aabd72083c7f96c3f9..d757c5765c336874399107cc14ccfbb4e71352c2 100644

--- a/chrome/browser/ui/webui/engagement/site_engagement_ui.cc

+++ b/chrome/browser/ui/webui/engagement/site_engagement_ui.cc

@@ -37,7 +37,7 @@ class SiteEngagementUIHandlerImpl : public SiteEngagementUIHandler {

SiteEngagementService* service = SiteEngagementService::Get(profile_);

- for (const std::pair<GURL, int>& info : service->GetScoreMap()) {

+ for (const std::pair<GURL, double>& info : service->GetScoreMap()) {

SiteEngagementInfoPtr origin_info(SiteEngagementInfo::New());

origin_info->origin = mojo::String::From(info.first);

origin_info->score = info.second;