Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6350)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/engagement/site_engagement.js

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/engagement/engagement_table.js ('K') | « chrome/browser/resources/engagement/engagement_table.js ('k') | chrome/browser/ui/webui/engagement/site_engagement.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/engagement/site_engagement.js
diff --git a/chrome/browser/resources/engagement/site_engagement.js b/chrome/browser/resources/engagement/site_engagement.js
index 911bbe594327e637ba3ff6014655587d7cc15f6e..584f5b4b3a654769edbdf85c03e90ca6e465934f 100644
--- a/chrome/browser/resources/engagement/site_engagement.js
+++ b/chrome/browser/resources/engagement/site_engagement.js
@@ -18,6 +18,10 @@ define('main', [
// Populate engagement table.
uiHandler.getSiteEngagementInfo().then(response => {
+ // Round each score to 2 decimal places.
+ response.info.forEach(function(x) {
+ x.score = Number(Math.round(x.score + 'e+2') + 'e-2');
Dan Beam 2015/10/29 00:50:00 nit: * 100 / 100 seems less awkward
calamity 2015/10/29 02:46:01 Done.
+ });
$('engagement-table').engagementInfo = response.info;
});
};
« chrome/browser/resources/engagement/engagement_table.js ('K') | « chrome/browser/resources/engagement/engagement_table.js ('k') | chrome/browser/ui/webui/engagement/site_engagement.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698