Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3263)

Unified Diff: chrome/browser/resources/engagement/engagement_table.css

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/engagement/engagement_table.css
diff --git a/chrome/browser/resources/engagement/engagement_table.css b/chrome/browser/resources/engagement/engagement_table.css
index 55318c35756a125e626b57a676623634837f0a42..937ba80f3415966d3ea4f95fd1abf490c50b0669 100644
--- a/chrome/browser/resources/engagement/engagement_table.css
+++ b/chrome/browser/resources/engagement/engagement_table.css
@@ -13,8 +13,24 @@ table th {
table th {
background: rgb(224, 236, 255);
+ cursor: pointer;
+ padding-bottom: 4px;
+ padding-top: 4px;
+ white-space: nowrap;
}
.origin-cell {
min-width: 500px;
}
+
+table tr:hover {
+ background: rgb(255, 255, 187);
+}
+
+.sort-column::after {
+ content: '\25B2';
Dan Beam 2015/10/29 00:50:00 any reason not to use '▲' directly?
calamity 2015/10/29 02:46:01 Done.
+}
+
+:host([sort-reverse_]) .sort-column::after {
Dan Beam 2015/10/29 00:50:00 nit: don't use _ in this case, IMO
calamity 2015/10/29 02:46:01 Done.
+ content: '\25BC';
Dan Beam 2015/10/29 00:50:00 same nit, re: ▼
calamity 2015/10/29 02:46:01 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698