Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7139)

Unified Diff: chrome/browser/resources/engagement/engagement_table.html

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/engagement/engagement_table.html
diff --git a/chrome/browser/resources/engagement/engagement_table.html b/chrome/browser/resources/engagement/engagement_table.html
index 434ee3d53db56949e048b1ee20c75ae89f9f904e..45aae2a78869546998a4aad05bd3e45b254a6276 100644
--- a/chrome/browser/resources/engagement/engagement_table.html
+++ b/chrome/browser/resources/engagement/engagement_table.html
@@ -6,12 +6,12 @@
<table>
<thead>
<tr>
- <th>Origin</th>
- <th>Points</th>
+ <th id="initial-sort-column" on-tap="handleSortColumnTap" sort-key="origin">Origin</th>
tsergeant 2015/10/27 23:35:34 Adding/removing children here for the indicator is
calamity 2015/10/28 04:26:50 Got rid of the span entirely and just used ::after
+ <th on-tap="handleSortColumnTap" sort-key="score">Points</th>
</tr>
</thead>
<tbody>
- <template is="dom-repeat" items="{{engagementInfo}}" as="info">
+ <template id="engagement-table-items" is="dom-repeat" items="{{engagementInfo}}" as="info">
<tr>
<td class="origin-cell">{{info.origin}}</td>
<td>{{info.score}}</td>

Powered by Google App Engine
This is Rietveld 408576698