Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/resources/engagement/engagement_table.css

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* Copyright 2015 The Chromium Authors. All rights reserved. 1 /* Copyright 2015 The Chromium Authors. All rights reserved.
2 * Use of this source code is governed by a BSD-style license that can be 2 * Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file. */ 3 * found in the LICENSE file. */
4 4
5 table, 5 table,
6 table td, 6 table td,
7 table th { 7 table th {
8 border: 1px solid #777; 8 border: 1px solid #777;
9 border-collapse: collapse; 9 border-collapse: collapse;
10 padding-left: 4px; 10 padding-left: 4px;
11 padding-right: 4px; 11 padding-right: 4px;
12 } 12 }
13 13
14 table th { 14 table th {
15 background: rgb(224, 236, 255); 15 background: rgb(224, 236, 255);
16 cursor: pointer;
17 padding-bottom: 4px;
18 padding-top: 4px;
19 white-space: nowrap;
16 } 20 }
17 21
18 .origin-cell { 22 .origin-cell {
19 min-width: 500px; 23 min-width: 500px;
20 } 24 }
25
26 table tr:hover {
27 background: rgb(255, 255, 187);
28 }
29
30 .sort-column::after {
31 content: '\25B2';
Dan Beam 2015/10/29 00:50:00 any reason not to use '▲' directly?
calamity 2015/10/29 02:46:01 Done.
32 }
33
34 :host([sort-reverse_]) .sort-column::after {
Dan Beam 2015/10/29 00:50:00 nit: don't use _ in this case, IMO
calamity 2015/10/29 02:46:01 Done.
35 content: '\25BC';
Dan Beam 2015/10/29 00:50:00 same nit, re: ▼
calamity 2015/10/29 02:46:01 Done.
36 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698