Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4624)

Unified Diff: chrome/browser/task_management/providers/web_contents/renderer_task.cc

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/web_contents/renderer_task.cc
diff --git a/chrome/browser/task_management/providers/web_contents/renderer_task.cc b/chrome/browser/task_management/providers/web_contents/renderer_task.cc
index ca30ac750dd15e99591707ebeb60063e23cd64a9..6b48475d33e8b8233db8721094e5bb5046519766 100644
--- a/chrome/browser/task_management/providers/web_contents/renderer_task.cc
+++ b/chrome/browser/task_management/providers/web_contents/renderer_task.cc
@@ -146,12 +146,13 @@ blink::WebCache::ResourceTypeStats RendererTask::GetWebCacheStats() const {
return webcache_stats_;
}
-void RendererTask::OnFaviconAvailable(const gfx::Image& image) {
-}
-
void RendererTask::OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
- bool icon_url_changed) {
- UpdateFavicon();
+ NotificationIconType notification_icon_type,
+ const GURL& icon_url,
+ bool icon_url_changed,
+ const gfx::Image& image) {
+ if (notification_icon_type == NON_TOUCH_16_DIP)
+ UpdateFavicon();
}
// static

Powered by Google App Engine
This is Rietveld 408576698