Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/tab_android.h ('k') | chrome/browser/extensions/api/tabs/tabs_event_router.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index 2d0e15b561ec78ae2a5e4b15d6782c5c23994661..ab262c6c622a195a47dadf1130bfc8d963982e79 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -388,7 +388,16 @@ void TabAndroid::Observe(int type,
}
}
-void TabAndroid::OnFaviconAvailable(const gfx::Image& image) {
+void TabAndroid::OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
+ NotificationIconType notification_icon_type,
+ const GURL& icon_url,
+ bool icon_url_changed,
+ const gfx::Image& image) {
+ if (notification_icon_type != NON_TOUCH_LARGEST &&
+ notification_icon_type != TOUCH_LARGEST) {
+ return;
+ }
+
SkBitmap favicon = image.AsImageSkia().GetRepresentation(1.0f).sk_bitmap();
if (favicon.empty())
return;
@@ -398,10 +407,6 @@ void TabAndroid::OnFaviconAvailable(const gfx::Image& image) {
gfx::ConvertToJavaBitmap(&favicon).obj());
}
-void TabAndroid::OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
- bool icon_url_changed) {
-}
-
void TabAndroid::Destroy(JNIEnv* env, jobject obj) {
delete this;
}
« no previous file with comments | « chrome/browser/android/tab_android.h ('k') | chrome/browser/extensions/api/tabs/tabs_event_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698