chrome/browser/android/tab_android.h - Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.h

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/tab_android.h

diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h

index d1a05d670050e44e47ba37ade6805f45061e0501..65d6e384232adb6431accf9394c2a76803533732 100644

--- a/chrome/browser/android/tab_android.h

+++ b/chrome/browser/android/tab_android.h

@@ -146,9 +146,11 @@ class TabAndroid : public CoreTabHelperDelegate,

const content::NotificationDetails& details) override;

// Overridden from favicon::FaviconDriverObserver:

- void OnFaviconAvailable(const gfx::Image& image) override;

void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,

- bool icon_url_changed) override;

+ NotificationIconType notification_icon_type,

+ const GURL& icon_url,

+ bool icon_url_changed,

+ const gfx::Image& image) override;

// Methods called from Java via JNI -----------------------------------------

« no previous file with comments | « no previous file | chrome/browser/android/tab_android.cc » ('j') | components/favicon/content/content_favicon_driver.cc » ('J')