Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/task_management/providers/web_contents/renderer_task.h

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_ 5 #ifndef CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_
6 #define CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_ 6 #define CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_
7 7
8 #include "chrome/browser/task_management/providers/task.h" 8 #include "chrome/browser/task_management/providers/task.h"
9 #include "components/favicon/core/favicon_driver_observer.h" 9 #include "components/favicon/core/favicon_driver_observer.h"
10 #include "content/public/browser/navigation_entry.h" 10 #include "content/public/browser/navigation_entry.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 int64 refresh_flags) override; 46 int64 refresh_flags) override;
47 Type GetType() const override; 47 Type GetType() const override;
48 int GetChildProcessUniqueID() const override; 48 int GetChildProcessUniqueID() const override;
49 base::string16 GetProfileName() const override; 49 base::string16 GetProfileName() const override;
50 int64 GetV8MemoryAllocated() const override; 50 int64 GetV8MemoryAllocated() const override;
51 int64 GetV8MemoryUsed() const override; 51 int64 GetV8MemoryUsed() const override;
52 bool ReportsWebCacheStats() const override; 52 bool ReportsWebCacheStats() const override;
53 blink::WebCache::ResourceTypeStats GetWebCacheStats() const override; 53 blink::WebCache::ResourceTypeStats GetWebCacheStats() const override;
54 54
55 // favicon::FaviconDriverObserver: 55 // favicon::FaviconDriverObserver:
56 void OnFaviconAvailable(const gfx::Image& image) override; 56 void OnFaviconUpdated(favicon::FaviconDriver* driver,
57 void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver, 57 NotificationIconType notification_icon_type,
58 bool icon_url_changed) override; 58 const GURL& icon_url,
59 bool icon_url_changed,
60 const gfx::Image& image) override;
59 61
60 protected: 62 protected:
61 // Returns the title of the given |web_contents|. 63 // Returns the title of the given |web_contents|.
62 static base::string16 GetTitleFromWebContents( 64 static base::string16 GetTitleFromWebContents(
63 content::WebContents* web_contents); 65 content::WebContents* web_contents);
64 66
65 // Returns the favicon of the given |web_contents| if any, and returns 67 // Returns the favicon of the given |web_contents| if any, and returns
66 // |nullptr| otherwise. 68 // |nullptr| otherwise.
67 static const gfx::ImageSkia* GetFaviconFromWebContents( 69 static const gfx::ImageSkia* GetFaviconFromWebContents(
68 content::WebContents* web_contents); 70 content::WebContents* web_contents);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 // The profile name associated with the browser context of the render view 105 // The profile name associated with the browser context of the render view
104 // host. 106 // host.
105 const base::string16 profile_name_; 107 const base::string16 profile_name_;
106 108
107 DISALLOW_COPY_AND_ASSIGN(RendererTask); 109 DISALLOW_COPY_AND_ASSIGN(RendererTask);
108 }; 110 };
109 111
110 } // namespace task_management 112 } // namespace task_management
111 113
112 #endif // CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H _ 114 #endif // CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H _
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698