Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/android/tab_android.h

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/jni_weak_ref.h" 10 #include "base/android/jni_weak_ref.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 // Overridden from SearchTabHelperDelegate: 142 // Overridden from SearchTabHelperDelegate:
143 void OnWebContentsInstantSupportDisabled( 143 void OnWebContentsInstantSupportDisabled(
144 const content::WebContents* web_contents) override; 144 const content::WebContents* web_contents) override;
145 145
146 // Overridden from NotificationObserver: 146 // Overridden from NotificationObserver:
147 void Observe(int type, 147 void Observe(int type,
148 const content::NotificationSource& source, 148 const content::NotificationSource& source,
149 const content::NotificationDetails& details) override; 149 const content::NotificationDetails& details) override;
150 150
151 // Overridden from favicon::FaviconDriverObserver: 151 // Overridden from favicon::FaviconDriverObserver:
152 void OnFaviconAvailable(const gfx::Image& image) override;
153 void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver, 152 void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
154 bool icon_url_changed) override; 153 NotificationIconType notification_icon_type,
154 const GURL& icon_url,
155 bool icon_url_changed,
156 const gfx::Image& image) override;
155 157
156 // Methods called from Java via JNI ----------------------------------------- 158 // Methods called from Java via JNI -----------------------------------------
157 159
158 void Destroy(JNIEnv* env, jobject obj); 160 void Destroy(JNIEnv* env, jobject obj);
159 void InitWebContents(JNIEnv* env, 161 void InitWebContents(JNIEnv* env,
160 jobject obj, 162 jobject obj,
161 jboolean incognito, 163 jboolean incognito,
162 jobject jcontent_view_core, 164 jobject jcontent_view_core,
163 jobject jweb_contents_delegate, 165 jobject jweb_contents_delegate,
164 jobject jcontext_menu_populator); 166 jobject jcontext_menu_populator);
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 scoped_ptr<content::WebContents> web_contents_; 260 scoped_ptr<content::WebContents> web_contents_;
259 scoped_ptr<chrome::android::TabWebContentsDelegateAndroid> 261 scoped_ptr<chrome::android::TabWebContentsDelegateAndroid>
260 web_contents_delegate_; 262 web_contents_delegate_;
261 263
262 scoped_ptr<browser_sync::SyncedTabDelegateAndroid> synced_tab_delegate_; 264 scoped_ptr<browser_sync::SyncedTabDelegateAndroid> synced_tab_delegate_;
263 265
264 DISALLOW_COPY_AND_ASSIGN(TabAndroid); 266 DISALLOW_COPY_AND_ASSIGN(TabAndroid);
265 }; 267 };
266 268
267 #endif // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 269 #endif // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698