Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_event_router.h

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_EVENT_ROUTER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_EVENT_ROUTER_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_EVENT_ROUTER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_EVENT_ROUTER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/containers/scoped_ptr_map.h" 10 #include "base/containers/scoped_ptr_map.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 content::WebContents* new_contents, 74 content::WebContents* new_contents,
75 int index) override; 75 int index) override;
76 void TabPinnedStateChanged(content::WebContents* contents, 76 void TabPinnedStateChanged(content::WebContents* contents,
77 int index) override; 77 int index) override;
78 78
79 // ZoomObserver: 79 // ZoomObserver:
80 void OnZoomChanged( 80 void OnZoomChanged(
81 const ui_zoom::ZoomController::ZoomChangedEventData& data) override; 81 const ui_zoom::ZoomController::ZoomChangedEventData& data) override;
82 82
83 // favicon::FaviconDriverObserver: 83 // favicon::FaviconDriverObserver:
84 void OnFaviconAvailable(const gfx::Image& image) override;
85 void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver, 84 void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
86 bool icon_url_changed) override; 85 NotificationIconType notification_icon_type,
86 const GURL& icon_url,
87 bool icon_url_changed,
88 const gfx::Image& image) override;
87 89
88 private: 90 private:
89 // "Synthetic" event. Called from TabInsertedAt if new tab is detected. 91 // "Synthetic" event. Called from TabInsertedAt if new tab is detected.
90 void TabCreatedAt(content::WebContents* contents, int index, bool active); 92 void TabCreatedAt(content::WebContents* contents, int index, bool active);
91 93
92 // Internal processing of tab updated events. Intended to be called when 94 // Internal processing of tab updated events. Intended to be called when
93 // there's any changed property. 95 // there's any changed property.
94 class TabEntry; 96 class TabEntry;
95 void TabUpdated(TabEntry* entry, 97 void TabUpdated(TabEntry* entry,
96 scoped_ptr<base::DictionaryValue> changed_properties); 98 scoped_ptr<base::DictionaryValue> changed_properties);
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 favicon_scoped_observer_; 203 favicon_scoped_observer_;
202 204
203 BrowserTabStripTracker browser_tab_strip_tracker_; 205 BrowserTabStripTracker browser_tab_strip_tracker_;
204 206
205 DISALLOW_COPY_AND_ASSIGN(TabsEventRouter); 207 DISALLOW_COPY_AND_ASSIGN(TabsEventRouter);
206 }; 208 };
207 209
208 } // namespace extensions 210 } // namespace extensions
209 211
210 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_EVENT_ROUTER_H_ 212 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_EVENT_ROUTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698