Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1407353010: YUV to RGB for x64 use registers instead of memory. (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, fbarchard
CC:
xhwang
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

YUV to RGB for x64 use registers instead of memory. On Arm the YVU to RGB conversions move constants into registers. This change does the same for 64 bit intel builds where additional registers are available. The AVX2 saves 3 instructions by because the 2nd argument needs to be a register, so a vmovdqu was avoided. x64 builds using memory: AVX2 I420ToARGB_Opt (3059 ms) SSSE3 I420ToARGB_Opt (3959 ms) Now using registers AVX2 I420ToARGB_Opt (2906 ms) SSSE3 I420ToARGB_Opt (3928 ms) TBR=harryjin@google.com BUG=libyuv:520 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/431cb3667a346136189952ff93974f4ac9e79d78

Patch Set 1 #

Patch Set 2 : bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -28 lines) Patch
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M source/row_gcc.cc View 38 chunks +114 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
fbarchard1
5 years, 1 month ago (2015-11-04 20:03:14 UTC) #1
fbarchard
no change in behavior for 32 bit. For 64 bit Was using memory AVX2 I420ToARGB_Opt ...
5 years, 1 month ago (2015-11-04 20:32:48 UTC) #4
fbarchard1
5 years, 1 month ago (2015-11-05 00:16:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
431cb3667a346136189952ff93974f4ac9e79d78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698