Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1407353007: Add a missing dependency from //chrome:chrome_android_core. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
Reviewers:
pkotwicz, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_android_shell_descriptors
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing dependency from //chrome:chrome_android_core. In the GN build, chrome_android_core has a dependency on chrome/common but it wasn't specified; this was causing a config to not get correctly propagated up and a header file to get miscompiled as a result. R=pkotwicz@chromium.org, jam@chromium.org BUG=547635 Committed: https://crrev.com/cf6c44898a090105716a5b14110df71728d63df3 Cr-Commit-Position: refs/heads/master@{#357035}

Patch Set 1 #

Patch Set 2 : merge to #357016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dirk Pranke
5 years, 1 month ago (2015-10-26 23:49:47 UTC) #1
Dirk Pranke
5 years, 1 month ago (2015-10-26 23:52:01 UTC) #2
pkotwicz
lgtm
5 years, 1 month ago (2015-10-27 00:09:40 UTC) #3
Dirk Pranke
On 2015/10/27 00:09:40, pkotwicz wrote: > lgtm jam@, can you OWNERS-approve this?
5 years, 1 month ago (2015-10-27 21:37:12 UTC) #4
jam
lgtm
5 years, 1 month ago (2015-10-29 16:12:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407353007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407353007/20001
5 years, 1 month ago (2015-10-30 02:10:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 03:02:24 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 03:03:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf6c44898a090105716a5b14110df71728d63df3
Cr-Commit-Position: refs/heads/master@{#357035}

Powered by Google App Engine
This is Rietveld 408576698