Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1407353003:
Expose more paper sizes when printing to PDF (Closed)
|
Created:
5 years, 2 months ago by AlexisBRENON Modified:
4 years, 11 months ago Reviewers:
Aleksey Shlyapnikov CC:
chromium-reviews, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description(Enable A0 pdf printing)
Expose more paper sizes when printing to PDF
R=alekseys@chromium.org
BUG=493830
Committed: https://crrev.com/0f09c18541d6793a79aba980b71118fb81298ab8
Cr-Commit-Position: refs/heads/master@{#370964}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add more paper sizes for PDF output #
Total comments: 1
Patch Set 3 : Remove not widely used formats #Patch Set 4 : Update AUTHORS file with right mail address #
Messages
Total messages: 26 (10 generated)
Description was changed from ========== Enable A0 pdf printing R=kmadhusu@chromium.org BUG= ========== to ========== Enable A0 pdf printing R=alekseys@chromium.org BUG= ==========
brenon.alexis@gmail.com changed reviewers: + alekseys@chromium.org - kmadhusu@chromium.org
Hello, Can you please review my small contribution which allow one to save as PDF an A0 document. Kind regards.
https://codereview.chromium.org/1407353003/diff/1/chrome/browser/resources/pr... File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/1407353003/diff/1/chrome/browser/resources/pr... chrome/browser/resources/print_preview/data/destination_store.js:346: 'ISO_A0': 'A0', There's crbug/493830 regarding exposing more media sizes for PDF printing. It's awkward to have A3, A4 and A0 in the list and since we're here, we need to add most popular media sizes, not just A0.
I added a comment to the bug to ask which sizes seem relevants. I'm waiting for answers for one or two days before a new commit. Kind, Alexis https://codereview.chromium.org/1407353003/diff/1/chrome/browser/resources/pr... File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/1407353003/diff/1/chrome/browser/resources/pr... chrome/browser/resources/print_preview/data/destination_store.js:346: 'ISO_A0': 'A0', On 2015/10/19 16:00:27, Aleksey Shlyapnikov wrote: > There's crbug/493830 regarding exposing more media sizes for PDF printing. It's > awkward to have A3, A4 and A0 in the list and since we're here, we need to add > most popular media sizes, not just A0. Acknowledged.
So, without more idea form the bug thread, I added more ISO_A* paper sizes and business cards. Regards, Alexis
https://codereview.chromium.org/1407353003/diff/20001/components/cloud_device... File components/cloud_devices/common/printer_description.cc (right): https://codereview.chromium.org/1407353003/diff/20001/components/cloud_device... components/cloud_devices/common/printer_description.cc:337: MAP_CLOUD_PRINT_MEDIA_TYPE(OM_UK_BUSINESS_CARD, 55, 85, kMmToUm)}; Why do you need these new sizes? Where did you get the actual dimensions? OM stands for "other metric", US size is definitely not metric, why did you put them in OM category? In case we end up adding those values, this enum corresponds to values defined here: https://developers.google.com/cloud-print/docs/cdd?hl=en#pds, please name values which are unique for Chrome in some distinctive way.
Also, can you link this issue to the bug I mentioned and change the subject accordingly?
Description was changed from ========== Enable A0 pdf printing R=alekseys@chromium.org BUG= ========== to ========== Enable A0 pdf printing R=alekseys@chromium.org BUG=493830 ==========
Description was changed from ========== Enable A0 pdf printing R=alekseys@chromium.org BUG=493830 ========== to ========== (Enable A0 pdf printing) Expose more paper sizes when printing to PDF R=alekseys@chromium.org BUG=493830 ==========
On 2015/11/05 00:54:10, Aleksey Shlyapnikov wrote: > Also, can you link this issue to the bug I mentioned and change the subject > accordingly? Sorry for the delay. I removed both not widely used formats and sticked to ISO formats. Alsa updated the issue to link it to the bug. Regards.
Remove not widely used formats for PDF printing
lgtm
The CQ bit was checked by brenon.alexis@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407353003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Build failed because of my bad mail address in the AUTHOR file: brenon.alexis+chromium@gmail.com instead of brenon.alexis@gmail.com. I made a new git cl update, but it doesn't appear here... What must I do?
The CQ bit was checked by brenon.alexis@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from alekseys@chromium.org Link to the patchset: https://codereview.chromium.org/1407353003/#ps60001 (title: "Update AUTHORS file with right mail address")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407353003/60001
On 2016/01/22 10:16:55, AlexisBRENON wrote: > Build failed because of my bad mail address in the AUTHOR file: > mailto:brenon.alexis+chromium@gmail.com instead of mailto:brenon.alexis@gmail.com. > I made a new git cl update, but it doesn't appear here... What must I do? It was my fault, sorry. Problem fixed.
Message was sent while issue was closed.
Description was changed from ========== (Enable A0 pdf printing) Expose more paper sizes when printing to PDF R=alekseys@chromium.org BUG=493830 ========== to ========== (Enable A0 pdf printing) Expose more paper sizes when printing to PDF R=alekseys@chromium.org BUG=493830 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== (Enable A0 pdf printing) Expose more paper sizes when printing to PDF R=alekseys@chromium.org BUG=493830 ========== to ========== (Enable A0 pdf printing) Expose more paper sizes when printing to PDF R=alekseys@chromium.org BUG=493830 Committed: https://crrev.com/0f09c18541d6793a79aba980b71118fb81298ab8 Cr-Commit-Position: refs/heads/master@{#370964} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0f09c18541d6793a79aba980b71118fb81298ab8 Cr-Commit-Position: refs/heads/master@{#370964} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
