Adds Media.Audio.InputStartupSuccessMac UMA stat for Mac OS X

media/audio/mac/audio_low_latency_input_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Implementation of AudioInputStream for Mac OS X using the special AUHAL
 // input Audio Unit present in OS 10.4 and later.
 // The AUHAL input Audio Unit is for low-latency audio I/O.
 //
 // Overview of operation:
 //
@@ skipping 21 matching lines @@
 //      latency;
 //   2) The delay between the actual recording instant and the time when the
 //      data packet is provided as a callback.
 //
 #ifndef MEDIA_AUDIO_MAC_AUDIO_LOW_LATENCY_INPUT_MAC_H_
 #define MEDIA_AUDIO_MAC_AUDIO_LOW_LATENCY_INPUT_MAC_H_
 
 #include <AudioUnit/AudioUnit.h>
 #include <CoreAudio/CoreAudio.h>
 
+#include "base/atomicops.h"
 #include "base/cancelable_callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/synchronization/lock.h"
+#include "base/threading/thread_checker.h"
 #include "base/time/time.h"
+#include "base/timer/timer.h"
 #include "media/audio/agc_audio_stream.h"
 #include "media/audio/audio_io.h"
 #include "media/audio/audio_parameters.h"
 #include "media/base/audio_block_fifo.h"
 
 namespace media {
 
 class AudioBus;
 class AudioManagerMac;
 class DataBuffer;
@@ skipping 51 matching lines @@
   // Gets the number of channels for a stream of audio data.
   int GetNumberOfChannelsFromStream();
 
   // Issues the OnError() callback to the |sink_|.
   void HandleError(OSStatus err);
 
   // Helper function to check if the volume control is avialable on specific
   // channel.
   bool IsVolumeSettableOnChannel(int channel);
 
+  // Helper methods to set and get atomic |input_callback_is_active_|.
+  void SetInputCallbackIsActive(bool active);
+  bool GetInputCallbackIsActive();
+
+  // Checks if a strem was started successfully and the audio unit also starts

[tommi (sloooow) - chröme, 2015/10/30 15:08:44]

strem -> stream

[henrika (OOO until Aug 14), 2015/10/30 15:56:35]

Done.

+  // to call InputProc() as it should. This method is called once when a timer
+  // expires 5 seconds after calling Start().
+  void CheckInputStartupSuccess();
+
+  // Verifies that Open(), Start(), Stop() and Close() are all called on the
+  // creating thread which is the main browser thread (CrBrowserMain) on Mac.
+  base::ThreadChecker thread_checker_;

[tommi (sloooow) - chröme, 2015/10/30 15:08:44]

nice

[henrika (OOO until Aug 14), 2015/10/30 15:56:35]

Thanks

+
   // Our creator, the audio manager needs to be notified when we close.
-  AudioManagerMac* manager_;
+  AudioManagerMac* const manager_;
 
   // Contains the desired number of audio frames in each callback.
   const size_t number_of_frames_;
 
   // Pointer to the object that will receive the recorded audio samples.
   AudioInputCallback* sink_;
 
   // Structure that holds the desired output format of the stream.
   // Note that, this format can differ from the device(=input) format.
   AudioStreamBasicDescription format_;
 
   // The special Audio Unit called AUHAL, which allows us to pass audio data
   // directly from a microphone, through the HAL, and to our application.
   // The AUHAL also enables selection of non default devices.
   AudioUnit audio_unit_;
 
   // The UID refers to the current input audio device.
-  AudioDeviceID input_device_id_;
+  const AudioDeviceID input_device_id_;
 
   // Provides a mechanism for encapsulating one or more buffers of audio data.
   AudioBufferList audio_buffer_list_;
 
   // Temporary storage for recorded data. The InputProc() renders into this
   // array as soon as a frame of the desired buffer size has been recorded.
   scoped_ptr<uint8[]> audio_data_buffer_;
 
   // True after successfull Start(), false after successful Stop().
   bool started_;
@@ skipping 10 matching lines @@
 
   // Used to defer Start() to workaround http://crbug.com/160920.
   base::CancelableClosure deferred_start_cb_;
 
   // Contains time of last successful call to AudioUnitRender().
   // Initialized first time in Start() and then updated for each valid
   // audio buffer. Used to detect long error sequences and to take actions
   // if length of error sequence is above a certain limit.
   base::TimeTicks last_success_time_;
 
+  // Is set to true on the internal AUHAL IO thread in the first input callback
+  // after Start() has bee called.
+  base::subtle::Atomic32 input_callback_is_active_;
+
+  // Timer which triggers CheckInputStartupSuccess() to verify that input
+  // callbacks have started as intended after a successful call to Start().
+  // This timer lives on the main browser thread.
+  scoped_ptr<base::OneShotTimer> input_callback_timer_;
+
   DISALLOW_COPY_AND_ASSIGN(AUAudioInputStream);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_AUDIO_MAC_AUDIO_LOW_LATENCY_INPUT_MAC_H_