Issue 140733004: Remove LayoutIndicator which is basically dead code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140733004: Remove LayoutIndicator which is basically dead code (Closed)

Created:
6 years, 11 months ago by atreat

Modified:
6 years, 11 months ago

Reviewers:
eseidel

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove LayoutIndicator which is basically dead code The LayoutIndicator is being used for one assert which seems excessive. The original idea seems to be on hold and the other patches for the parallel layout effort have been removed as well. R=eseidel BUG=289678 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165258

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -114 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	3 chunks	+0 lines, -4 lines	0 comments	Download
D	Source/core/rendering/LayoutIndicator.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	Source/core/rendering/LayoutIndicator.cpp	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderView.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/140733004/1

6 years, 11 months ago (2014-01-16 22:14:51 UTC) #3

Message was sent while issue was closed.

Change committed as 165258

Expand Messages | Collapse Messages