Adds the possibility of setting a Code object as the callback of a FunctionTemplate.

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 5c1e9aa653684776f9a1cf4d307b941f8dbacc35..718fd99ae4b63b907e7627fdf4a89f2ab9165f62 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -7765,8 +7765,10 @@ MaybeHandle<Object> JSObject::DefineAccessor(LookupIterator* it,
     }
   }
 
-  DCHECK(getter->IsCallable() || getter->IsUndefined() || getter->IsNull());
-  DCHECK(setter->IsCallable() || setter->IsUndefined() || setter->IsNull());
+  DCHECK(getter->IsCallable() || getter->IsUndefined() || getter->IsNull() ||
+         getter->IsCode());

[Benedikt Meurer, 2015/11/12 04:31:21]

This will be hard to maintain everywhere. AFAIR there are various places where
we expect getters/setters to be callable (or null/undefined). How about wrapping
the code object into a helper object that is callable?

[epertoso, 2015/11/13 01:39:28]

Actually we don't need it, at this point the FunctionTemplateInfo has already
been instantiated and we get a JSFunction. My bad, it was left over from some
previous experiment.

+  DCHECK(setter->IsCallable() || setter->IsUndefined() || setter->IsNull() ||
+         setter->IsCode());
   // At least one of the accessors needs to be a new value.
   DCHECK(!getter->IsNull() || !setter->IsNull());
   if (!getter->IsNull()) {