Adds the possibility of setting a Code object as the callback of a FunctionTemplate.

src/api-natives.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api-natives.h"
 
 #include "src/api.h"
 #include "src/isolate-inl.h"
 #include "src/lookup.h"
 #include "src/messages.h"
@@ skipping 420 matching lines @@
     info->set_property_accessors(*list);
   }
   NeanderArray array(list);
   array.add(isolate, property);
 }
 
 
 Handle<JSFunction> ApiNatives::CreateApiFunction(
     Isolate* isolate, Handle<FunctionTemplateInfo> obj,
     Handle<Object> prototype, ApiInstanceType instance_type) {
-  Handle<Code> code = isolate->builtins()->HandleApiCall();
+  Handle<Code> code;
+  if (obj->call_code()->IsCallHandlerInfo() &&
+      !handle(CallHandlerInfo::cast(obj->call_code()))

[Toon Verwaest, 2015/11/18 08:51:46]

Why is this wrapped in a handle before calling fast_handler?

[epertoso, 2015/11/20 15:27:13]

Removed.

+           ->fast_handler()
+           ->IsUndefined()) {

[vogelheim, 2015/11/18 17:30:05]

nitpick: Why !..->IsUndefined(), instead of ...->IsCode() ?

(They do the same thing, it's just with the negation being 2 lines above the
thing to be negated I at first just overlooked it.)

[epertoso, 2015/11/20 15:27:13]

Done.

+    code = isolate->builtins()->HandleFastApiCall();
+  } else {
+    code = isolate->builtins()->HandleApiCall();
+  }
   Handle<Code> construct_stub = isolate->builtins()->JSConstructStubApi();
 
   obj->set_instantiated(true);
   Handle<JSFunction> result;
   if (obj->remove_prototype()) {
     result = isolate->factory()->NewFunctionWithoutPrototype(
         isolate->factory()->empty_string(), code);
   } else {
     int internal_field_count = 0;
     if (!obj->instance_template()->IsUndefined()) {
@@ skipping 156 matching lines @@
     Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i)));
     JSObject::SetAccessor(result, accessor).Assert();
   }
 
   DCHECK(result->shared()->IsApiFunction());
   return result;
 }
 
 }  // namespace internal
 }  // namespace v8