Adds the possibility of setting a Code object as the callback of a FunctionTemplate.

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 4404 matching lines @@
  * \endcode
  */
 class V8_EXPORT FunctionTemplate : public Template {
  public:
   /** Creates a function template.*/
   static Local<FunctionTemplate> New(
       Isolate* isolate, FunctionCallback callback = 0,
       Local<Value> data = Local<Value>(),
       Local<Signature> signature = Local<Signature>(), int length = 0);
 
+#ifdef V8_FAST_ACCESSORS
+  /** Creates a function template with a code object. */
+  static Local<FunctionTemplate> New(
+      Isolate* isolate, Local<Value> fast_handler, FunctionCallback callback,

[vogelheim, 2015/11/18 17:30:05]

nitpick: Wouldn't it make more sense to have fast_handler be an optional
argument, following callback? That would also be consistent with the
SetCallHandler signature.

I guess then we can't really ambiguate the two overloads, so maybe just make it
an optional parameter for the existing FunctionTemplate::New?

(Decide as you see fit, though. This is #ifdef-ed and trivial to change later
on, when we have a better idea how the API should look like.)

[epertoso, 2015/11/20 15:27:13]

Resolved according to the offline discussion we had.

+      Local<Value> data = Local<Value>(),
+      Local<Signature> signature = Local<Signature>(), int length = 0);
+#endif
+
   /** Returns the unique function instance in the current execution context.*/
   V8_DEPRECATE_SOON("Use maybe version", Local<Function> GetFunction());
   V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
       Local<Context> context);
 
   /**
    * Set the call-handler callback for a FunctionTemplate.  This
    * callback is called whenever the function created from this
    * FunctionTemplate is called.
    */
   void SetCallHandler(FunctionCallback callback,
-                      Local<Value> data = Local<Value>());
+                      Local<Value> data = Local<Value>(),
+                      Local<Value> fast_handler = Local<Value>());

[vogelheim, 2015/11/18 17:30:05]

The FunctionTemplate::New version is #ifdef-ed, but SetCallHandler isn't. 
That's kinda weird.

Maybe either provide two overloads, or just #ifdef the implementation [1], or
maybe just #ifdef one parameter [2], like so:

[1]: #ifdef ... #else CRASH() #endif
[2] void SetCallHandler(..., ...
    #ifdef
       , Local<Value> ...
    #endif

Not sure what our default strategy for this kind of thing is...

[epertoso, 2015/11/20 15:27:13]

Removed the #ifdefs.

 
   /** Set the predefined length property for the FunctionTemplate. */
   void SetLength(int length);
 
   /** Get the InstanceTemplate. */
   Local<ObjectTemplate> InstanceTemplate();
 
   /** Causes the function template to inherit from a parent function template.*/
   void Inherit(Local<FunctionTemplate> parent);
 
@@ skipping 4030 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_