Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1407273007: mojo_benchmark: don't duplicate benchmark name in variant name. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

mojo_benchmark: don't duplicate benchmark name in variant name. Thich patch separates benchmark_name (original name of the benchmark from the spec file) from variant_name (just the name of the variant, e.g. "cold start"). This will allow to record the results hierarchically without duplication (ie. as "benchmark_name/variant_name"). R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/76400e028dee21ae506cf016f52ad2dc594defad

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M mojo/devtools/common/mojo_benchmark View 1 5 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Etienne, ptal.
5 years, 1 month ago (2015-10-26 14:25:47 UTC) #2
etiennej
lgtm
5 years, 1 month ago (2015-10-27 10:37:32 UTC) #3
ppi
5 years, 1 month ago (2015-10-27 10:56:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
76400e028dee21ae506cf016f52ad2dc594defad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698