src/IceCfgNode.cpp - Issue 1407273006: Generate block labels in the ARM hybrid assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfgNode.cpp

Issue 1407273006: Generate block labels in the ARM hybrid assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfgNode.cpp

diff --git a/src/IceCfgNode.cpp b/src/IceCfgNode.cpp

index f6c63797d87d761fe50f558facc168c5fa140953..71a0384c674e31881206f8c99474eb6aefa3e241 100644

--- a/src/IceCfgNode.cpp

+++ b/src/IceCfgNode.cpp

@@ -1184,7 +1184,7 @@ void CfgNode::emitIAS(Cfg *Func) const {

// TODO(stichnot): When sandboxing, defer binding the node label until just

// before the first instruction is emitted, to reduce the chance that a

// padding nop is a branch target.

- Asm->bindCfgNodeLabel(getIndex());

+ Asm->bindCfgNodeLabel(this);

for (const Inst &I : Phis) {

if (I.isDeleted())

continue;

« no previous file with comments | « src/IceAssemblerX86BaseImpl.h ('k') | src/IceInstARM32.h » ('j') | no next file with comments »