src/IceAssembler.h - Issue 1407273006: Generate block labels in the ARM hybrid assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssembler.h

Issue 1407273006: Generate block labels in the ARM hybrid assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssembler.h

diff --git a/src/IceAssembler.h b/src/IceAssembler.h

index 5e7815d321718308611d1f995edb7d45b41f0099..5068f99626302d92faf051826be4df6b2128f6f2 100644

--- a/src/IceAssembler.h

+++ b/src/IceAssembler.h

@@ -276,9 +276,8 @@ public:

/// Get the label for a CfgNode.

virtual Label *getCfgNodeLabel(SizeT NodeNumber) = 0;

- /// Mark the current text location as the start of a CFG node (represented by

- /// NodeNumber).

- virtual void bindCfgNodeLabel(SizeT NodeNumber) = 0;

+ /// Mark the current text location as the start of a CFG node.

+ virtual void bindCfgNodeLabel(const CfgNode *Node) = 0;

virtual bool fixupIsPCRel(FixupKind Kind) const = 0;

« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | no next file with comments »