Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: net/http/transport_security_state.h

Issue 1407263010: [Cronet] Public key pinning for Java API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Hostname conversion to ASCII and IPv4-like hostname validation Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/transport_security_state.h
diff --git a/net/http/transport_security_state.h b/net/http/transport_security_state.h
index d46993b1782d39e801eebf94738cabf853826f20..bb6cd1403ef308223d127f114e5d6d54a5eb6f27 100644
--- a/net/http/transport_security_state.h
+++ b/net/http/transport_security_state.h
@@ -292,8 +292,10 @@ class NET_EXPORT TransportSecurityState
const base::Time& expiry,
bool include_subdomains);
- // Adds explicitly-specified data as if it was processed from an
- // HPKP header (used for net-internals and unit tests).
+ // Adds explicitly-specified data as if it was processed from an HPKP header.
+ // Note: This method will persist the HPKP if |Delegate| is set. Make sure
pauljensen 2015/11/30 18:18:31 |Delegate| is set->a Delegate is present (without
kapishnikov 2015/11/30 20:12:38 Done.
+ // that the delegate is |NULL| if the persistence is not desired.
+ // See |SetDelegate| method for more details.
void AddHPKP(const std::string& host,
const base::Time& expiry,
bool include_subdomains,

Powered by Google App Engine
This is Rietveld 408576698