Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUtilTest.java

Issue 1407263010: [Cronet] Public key pinning for Java API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Validation of unicode host names Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 package org.chromium.net;
5
6 import android.test.suitebuilder.annotation.SmallTest;
7
8 import org.chromium.base.test.util.Feature;
9
10 /**
11 * Tests CronetUtil class.
12 */
13 public class CronetUtilTest extends CronetTestBase {
14 @SmallTest
15 @Feature({"Cronet"})
16 public void testHostNameValidation() throws Exception {
17 // Valid host names.
18 assertValidHostName("domain.com");
19 assertValidHostName("section4.domain.info");
20 assertValidHostName("44.domain44.info");
21 assertValidHostName("very.long.long.long.long.long.long.long.domain.com" );
22 assertValidHostName("host");
23 assertValidHostName("новости.ру");
24 // Invalid host names.
25 assertInvalidHostName("domain.com:300");
estark 2015/11/10 19:04:16 IPv6 test cases would be good, I think.
kapishnikov 2015/11/10 22:33:33 Will add it in the next PS.
26 assertInvalidHostName("http://domain.com");
27 assertInvalidHostName("domain.com:");
28 assertInvalidHostName("domain.com/");
29 assertInvalidHostName("новости.ру:");
30 assertInvalidHostName("новости.ру/");
31 }
32
33 @SmallTest
34 @Feature({"Cronet"})
35 public void testIPv4Validation() throws Exception {
36 // Valid IPv4 addresses.
37 assertValidIPv4("127.0.0.1");
38 assertValidIPv4("1.0.0.10");
39 // Invalid IPv4 addresses.
40 assertInvalidIPv4("domain.com");
41 assertInvalidIPv4("новости.ру");
42 assertInvalidIPv4("256.0.0.1");
43 assertInvalidIPv4("127.0.0.299");
44 assertInvalidIPv4("127.0.0.");
45 assertInvalidIPv4("127.0.0");
46 assertInvalidIPv4("127.0.0.a");
47 assertInvalidIPv4("127.0.0.1:80");
48 assertInvalidIPv4("127.0.0.1:80/");
49 assertInvalidIPv4("http://127.0.0.1:80");
50 }
51
52 private void assertValidHostName(String hostName) {
53 boolean valid = CronetUtil.isValidHostName(hostName);
54 assertTrue(hostName + " should be a valid host name", valid);
55 }
56
57 private void assertInvalidHostName(String hostName) {
58 boolean valid = CronetUtil.isValidHostName(hostName);
59 assertFalse(hostName + " should be an invalid host name", valid);
60 }
61
62 private void assertValidIPv4(String addr) {
63 boolean valid = CronetUtil.isValidIPv4(addr);
64 assertTrue(addr + " should be a valid IPv4 address", valid);
65 }
66
67 private void assertInvalidIPv4(String addr) {
68 boolean valid = CronetUtil.isValidIPv4(addr);
69 assertFalse(addr + " should be an invalid IPv4 address", valid);
70 }
71 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698