Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUtilTest.java

Issue 1407263010: [Cronet] Public key pinning for Java API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added host name verification + review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 package org.chromium.net;
5
6 import android.test.suitebuilder.annotation.SmallTest;
7
8 import org.chromium.base.test.util.Feature;
9
10 /**
11 * Tests CronetUtil class.
12 */
13 public class CronetUtilTest extends CronetTestBase {
14 @SmallTest
15 @Feature({"Cronet"})
16 public void testHostNameValidation() throws Exception {
17 // Valid host names.
18 assertValidHostName("domain.com");
19 assertValidHostName("section4.domain.info");
20 assertValidHostName("44.domain44.info");
21 assertValidHostName("very.long.long.long.long.long.long.long.domain.com" );
22 assertValidHostName("host");
23 // Invalid host names.
24 assertInvalidHostName("domain.com:300");
25 assertInvalidHostName("http://domain.com");
26 assertInvalidHostName("domain.com:");
27 assertInvalidHostName("domain.com/");
28 }
29
30 @SmallTest
31 @Feature({"Cronet"})
32 public void testIPv4Validation() throws Exception {
33 // Valid IPv4 addresses.
34 assertValidIPv4("127.0.0.1");
35 assertValidIPv4("1.0.0.10");
36 // Invalid IPv4 addresses.
37 assertInvalidIPv4("256.0.0.1");
38 assertInvalidIPv4("127.0.0");
39 assertInvalidIPv4("127.0.0.a");
40 assertInvalidIPv4("127.0.0.1:80");
41 assertInvalidIPv4("127.0.0.1:80/");
42 assertInvalidIPv4("http://127.0.0.1:80");
43 }
44
45 private void assertValidHostName(String hostName) {
46 boolean valid = CronetUtil.isValidHostName(hostName);
47 assertTrue(hostName + " should be a valid host name", valid);
48 }
49
50 private void assertInvalidHostName(String hostName) {
51 boolean valid = CronetUtil.isValidHostName(hostName);
52 assertFalse(hostName + " should be an invalid host name", valid);
53 }
54
55 private void assertValidIPv4(String addr) {
56 boolean valid = CronetUtil.isValidIPv4(addr);
57 assertTrue(addr + " should be a valid IPv4 address", valid);
58 }
59
60 private void assertInvalidIPv4(String addr) {
61 boolean valid = CronetUtil.isValidIPv4(addr);
62 assertFalse(addr + " should be an invalid IPv4 address", valid);
63 }
64 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698