[Chromecast] Allow CMA backend to notify of key expiry

[Chromecast] Allow CMA backend to notify of key expiry

This allows CMA backend implementations to notify us when
keys have expired.  We will need a corresponding internal
CL to handle this event in the CDM and send keystatuseschange
event upward to JS.

BUG=internal b/22702612

Committed: https://crrev.com/4d1b80a42727d3411c4ed6c60ce6cf0b3372b99e
Cr-Commit-Position: refs/heads/master@{#360523}

[halliwell, 2015-11-05 23:35:58]

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 23:39:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407253007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407253007/1

[commit-bot: I haz the power, 2015-11-06 00:16:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-06 00:16:52]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[halliwell, 2015-11-18 00:51:42]

Description was changed from

==========
[Chromecast] Allow CMA backend to notify of key expiry

This allows CMA backend implementations to notify us when
keys have expired.  We will need a corresponding internal
CL to handle this event in the CDM and send keystatuseschange
event upward to JS.

BUG=internal b/22702612
==========

to

==========
[Chromecast] Allow CMA backend to notify of key expiry

This allows CMA backend implementations to notify us when
keys have expired.  We will need a corresponding internal
CL to handle this event in the CDM and send keystatuseschange
event upward to JS.

BUG=internal b/22702612
==========

[halliwell, 2015-11-18 00:51:43]

halliwell@chromium.org changed reviewers:
+ lcwu@chromium.org, yucliu@chromium.org

[halliwell, 2015-11-18 00:51:54]

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

[halliwell, 2015-11-18 00:52:37]

This is ready to review now: we are passing the basic key expiry test case :) 
Internal reviews to follow soon.

[commit-bot: I haz the power, 2015-11-18 00:53:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407253007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407253007/80001

[yucliu1, 2015-11-18 01:06:36]

https://codereview.chromium.org/1407253007/diff/80001/chromecast/media/cma/pi...
File chromecast/media/cma/pipeline/media_pipeline_impl.cc (right):

https://codereview.chromium.org/1407253007/diff/80001/chromecast/media/cma/pi...
chromecast/media/cma/pipeline/media_pipeline_impl.cc:163: if (cdm_)
Is it possible for !cdm_ happen? If this did happen, I think we need to fire it
later when cdm_ is ready. Otherwise, add a DCHECK here?

[commit-bot: I haz the power, 2015-11-18 01:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 01:07:40]

Dry run: This issue passed the CQ dry run.

[halliwell, 2015-11-18 02:32:18]

https://codereview.chromium.org/1407253007/diff/80001/chromecast/media/cma/pi...
File chromecast/media/cma/pipeline/media_pipeline_impl.cc (right):

https://codereview.chromium.org/1407253007/diff/80001/chromecast/media/cma/pi...
chromecast/media/cma/pipeline/media_pipeline_impl.cc:163: if (cdm_)
On 2015/11/18 01:06:36, yucliu1 wrote:
> Is it possible for !cdm_ happen? If this did happen, I think we need to fire
it
> later when cdm_ is ready. Otherwise, add a DCHECK here?

Agreed, I don't think it's possible.  A key can only change status if we are
using a CDM in the first place.  Changed to a DCHECK.

[yucliu1, 2015-11-18 19:28:26]

https://codereview.chromium.org/1407253007/diff/100001/chromecast/media/cdm/b...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/1407253007/diff/100001/chromecast/media/cdm/b...
chromecast/media/cdm/browser_cdm_cast.cc:144: new
::media::CdmKeyInformation(key.first,
The constructor with arguments isn't available in m47 yet. Consider using the
default one, or making local changes when cherry-pick?

[halliwell, 2015-11-18 19:32:32]

https://codereview.chromium.org/1407253007/diff/100001/chromecast/media/cdm/b...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/1407253007/diff/100001/chromecast/media/cdm/b...
chromecast/media/cdm/browser_cdm_cast.cc:144: new
::media::CdmKeyInformation(key.first,
On 2015/11/18 19:28:26, yucliu1 wrote:
> The constructor with arguments isn't available in m47 yet. Consider using the
> default one, or making local changes when cherry-pick?

Correct, I have been working with local changes to test in m47.  It's not a big
change.

[yucliu1, 2015-11-18 20:58:20]

On 2015/11/18 19:32:32, halliwell wrote:
>
https://codereview.chromium.org/1407253007/diff/100001/chromecast/media/cdm/b...
> File chromecast/media/cdm/browser_cdm_cast.cc (right):
> 
>
https://codereview.chromium.org/1407253007/diff/100001/chromecast/media/cdm/b...
> chromecast/media/cdm/browser_cdm_cast.cc:144: new
> ::media::CdmKeyInformation(key.first,
> On 2015/11/18 19:28:26, yucliu1 wrote:
> > The constructor with arguments isn't available in m47 yet. Consider using
the
> > default one, or making local changes when cherry-pick?
> 
> Correct, I have been working with local changes to test in m47.  It's not a
big
> change.

lgtm

[halliwell, 2015-11-19 03:12:39]

The CQ bit was checked by halliwell@chromium.org

[commit-bot: I haz the power, 2015-11-19 03:13:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407253007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407253007/100001

[commit-bot: I haz the power, 2015-11-19 04:44:05]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-19 04:45:03]

Patchset 6 (id:??) landed as
https://crrev.com/4d1b80a42727d3411c4ed6c60ce6cf0b3372b99e
Cr-Commit-Position: refs/heads/master@{#360523}