Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: mojo/runner/android/android_handler.cc

Issue 1407233017: Define a Java-side global application context. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/runner/android/android_handler.cc
diff --git a/mojo/runner/android/android_handler.cc b/mojo/runner/android/android_handler.cc
index 354720a4968621bd71506983ee8b0cab1d7e936c..7a7579b6030eac1179a8bdeb59f1d94c17bea152 100644
--- a/mojo/runner/android/android_handler.cc
+++ b/mojo/runner/android/android_handler.cc
@@ -51,6 +51,7 @@ void RunAndroidApplication(JNIEnv* env,
// access the Android ApplicationContext in which they are run. If the
// application library exports the InitApplicationContext function, we will
// set it there.
+ // TODO: what to do about this?
Torne 2015/11/06 16:43:19 Mojo folks: is it reasonable to remove this mechan
qsr 2015/11/13 14:36:06 Unfortunately, I don't think you can do this.
const char* init_application_context_name = "InitApplicationContext";
typedef void (*InitApplicationContextFn)(
const base::android::JavaRef<jobject>&);

Powered by Google App Engine
This is Rietveld 408576698