Define a Java-side global application context.

remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting.jni;
 
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Point;
 import android.os.Looper;
 
+import org.chromium.base.ContextUtils;
 import org.chromium.base.Log;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.base.annotations.JNINamespace;
 import org.chromium.chromoting.CapabilityManager;
 import org.chromium.chromoting.R;
 import org.chromium.chromoting.SessionAuthenticator;
 
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
 
@@ skipping 115 matching lines @@
     /** Bitmap holding the cursor shape. Accessed on the graphics thread. */
     private static Bitmap sCursorBitmap = null;
 
     /** Capability Manager through which capabilities and extensions are handled. */
     private static CapabilityManager sCapabilityManager = CapabilityManager.getInstance();
 
     /**
      * To be called once from the main Activity. Any subsequent calls will update the application
      * context, but not reload the library. This is useful e.g. when the activity is closed and the
      * user later wants to return to the application. Called on the UI thread.
+     * THIS IS SKETCHY: the code doesn't update the app context, and the comment doesn't make sense.

[Torne, 2015/11/06 16:51:34]

remoting folks: the comment here isn't consistent with the actual function
implementation, it doesn't update the context if you call it with a different
context (it can't, if you do that it would crash on the native side), and the
comment makes it seem like the context here is actually an Activity, which is
not something you are allowed to set as an application context - if "context"
here is an activity then you need to pass down "context.getApplicationContext()"
instead.

Is the comment just outdated and you are actually using the app context here, or
is the code wrong?

[Lambros, 2015/11/06 19:46:03]

The comment seems to be outdated, probably all they way back to the initial
check-in. Sorry for the confusion!

This loadLibrary() function gets called from our main activity's OnCreate(),
passing in the Activity for the Context.

The code looks wrong - we should be passing the Application context to
Chromium's machinery, not the Activity. Looking at the native code, I don't
think we use |context| in any other way, so feel free to fix it to pass the
Application context instead.

The comment here should probably just say something simple like "Loads and
initializes the native code. Called on the UI thread."

I'm not sure whether we should fix the caller to pass in the Application
context, or whether we should do context.getApplicationContext() here? I don't
think it matters either way.

      */
     public static void loadLibrary(Context context) {
         if (sLoaded) return;
 
         System.loadLibrary("remoting_client_jni");
 
-        nativeLoadNative(context);
+        ContextUtils.initApplicationContext(context);
+        nativeLoadNative();
         sLoaded = true;
     }
 
     /** Performs the native portion of the initialization. */
-    private static native void nativeLoadNative(Context context);
+    private static native void nativeLoadNative();
 
     /*
      * API/OAuth2 keys access.
      */
     public static native String nativeGetApiKey();
     public static native String nativeGetClientId();
     public static native String nativeGetClientSecret();
 
     /** Returns whether the client is connected. */
     public static boolean isConnected() {
@@ skipping 314 matching lines @@
     public static void sendExtensionMessage(String type, String data) {
         if (!sConnected) {
             return;
         }
 
         nativeSendExtensionMessage(type, data);
     }
 
     private static native void nativeSendExtensionMessage(String type, String data);
 }