Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1407233016: Android: Workaround for ftruncate() issues. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
acleung1
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Android: Workaround for ftruncate() issues. This works around a bug in M that prevents Breakpad from using ftruncate() in the renderer process. To do this, skip the calls to ftruncate() when allocating bigger minidump files and strictly depends on write() to append to the end. It might be less efficient but this is probably less of an issue on SD cards. It is much better than not getting crash reports. BUG=542840 Original CL: https://codereview.appspot.com/273880044/ Original CL Author: acleung@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/fe64fd4aa28bea49d93035279b32f318ed7de9cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -3 lines) Patch
M src/client/minidump_file_writer.cc View 4 chunks +69 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR. I rewrote the CL description a bit to remove references to we/us/I.
5 years, 1 month ago (2015-11-05 23:44:53 UTC) #2
Lei Zhang
Committed patchset #1 (id:1) manually as fe64fd4aa28bea49d93035279b32f318ed7de9cb (presubmit successful).
5 years, 1 month ago (2015-11-05 23:45:05 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-05 23:48:16 UTC) #4
Message was sent while issue was closed.
Hmm, the actual commit used my google.com address. Oh well.

Powered by Google App Engine
This is Rietveld 408576698