Add image assets for WebUSB notification.

Add image assets for WebUSB notification.

This change adds the missing image assets for the notification displayed
when a WebUSB-enabled device is connected to the system.

BUG=492204
Committed: https://crrev.com/137122cd8ba7036907425da2f550251bc7b423f4
Cr-Commit-Position: refs/heads/master@{#357235}

[Reilly Grant (use Gerrit), 2015-10-30 22:11:20]

Description was changed from

==========
Add image assets for WebUSB notification.

This change adds the missing image assets for the notification displayed
when a WebUSB-enabled device is connected to the system.

BUG=492204
==========

to

==========
Add image assets for WebUSB notification.

This change adds the missing image assets for the notification displayed
when a WebUSB-enabled device is connected to the system.

BUG=492204
==========

[Reilly Grant (use Gerrit), 2015-10-30 22:11:20]

reillyg@chromium.org changed reviewers:
+ oshima@chromium.org, thestig@chromium.org

[Reilly Grant (use Gerrit), 2015-10-30 22:11:55]

Please take a look.

[Lei Zhang, 2015-10-30 22:22:09]

lgtm

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
File chrome/browser/chrome_webusb_browser_client.cc (right):

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
chrome/browser/chrome_webusb_browser_client.cc:15: #include
"grit/theme_resources.h"
chrome/grit/theme_resources.h ?

[Reilly Grant (use Gerrit), 2015-10-30 22:33:16]

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
File chrome/browser/chrome_webusb_browser_client.cc (right):

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
chrome/browser/chrome_webusb_browser_client.cc:15: #include
"grit/theme_resources.h"
On 2015/10/30 22:22:09, Lei Zhang wrote:
> chrome/grit/theme_resources.h ?

I guess something is putting chrome in the include path? There are a lot of
instances of #include "grit/..." in the tree even though there is no toplevel
grit directory.

[oshima, 2015-10-30 22:50:47]

lgtm

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
File chrome/browser/chrome_webusb_browser_client.cc (right):

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
chrome/browser/chrome_webusb_browser_client.cc:15: #include
"grit/theme_resources.h"
On 2015/10/30 22:33:15, Reilly Grant wrote:
> On 2015/10/30 22:22:09, Lei Zhang wrote:
> > chrome/grit/theme_resources.h ?
> 
> I guess something is putting chrome in the include path? There are a lot of
> instances of #include "grit/..." in the tree even though there is no toplevel
> grit directory.

This is generated file.

I believe grit/theme_resources.h is old way and works for compatibility reason.
new code should use chrome/grit/theme_resources.h

[Reilly Grant (use Gerrit), 2015-10-30 22:54:31]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-10-30 22:54:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1407233014/#ps20001
(title: "Fix theme_resources.h path.")

[commit-bot: I haz the power, 2015-10-30 22:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407233014/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407233014/20001

[commit-bot: I haz the power, 2015-10-31 00:09:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-31 00:10:16]

Patchset 2 (id:??) landed as
https://crrev.com/137122cd8ba7036907425da2f550251bc7b423f4
Cr-Commit-Position: refs/heads/master@{#357235}

[Lei Zhang, 2015-10-31 00:50:36]

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
File chrome/browser/chrome_webusb_browser_client.cc (right):

https://codereview.chromium.org/1407233014/diff/1/chrome/browser/chrome_webus...
chrome/browser/chrome_webusb_browser_client.cc:15: #include
"grit/theme_resources.h"
On 2015/10/30 22:33:15, Reilly Grant wrote:
> On 2015/10/30 22:22:09, Lei Zhang wrote:
> > chrome/grit/theme_resources.h ?
> 
> I guess something is putting chrome in the include path? There are a lot of
> instances of #include "grit/..." in the tree even though there is no toplevel
> grit directory.

Yes, there's a bug to fix all the grit/ ones, but I lost interest. May get back
to one some day.