Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1407233006: [turbofan] Add test case for stores to properties that are also present on prototype. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add test case for stores to properties that are also present on prototype. R=verwaest@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/2ab54f109e04bbf2fd0e34959535d70bc253dfac Cr-Commit-Position: refs/heads/master@{#31517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
A + test/mjsunit/compiler/regress-4470-1.js View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-23 10:52:39 UTC) #1
Benedikt Meurer
Hey Toon, The regression test we talked about offline. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-23 10:53:09 UTC) #2
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-23 10:55:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407233006/1
5 years, 2 months ago (2015-10-23 10:56:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 12:09:50 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 12:09:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ab54f109e04bbf2fd0e34959535d70bc253dfac
Cr-Commit-Position: refs/heads/master@{#31517}

Powered by Google App Engine
This is Rietveld 408576698