Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140723002: Test non-crashing updating of worker scope event handlers. (Closed)

Created:
6 years, 11 months ago by sof
Modified:
6 years, 11 months ago
CC:
blink-reviews, dcarney, adamk
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Test non-crashing updating of worker scope event handlers. Add a pair of tests to verify that repeatedly updating attribute event handlers on a worker global scope doesn't fall over. R=jochen@chromium.org,dslomov@chromium.org BUG=239669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
A LayoutTests/fast/workers/resources/shared-worker-replace-event-handler.js View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/workers/resources/worker-replace-event-handler.js View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/workers/shared-worker-replace-event-handler.html View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/workers/shared-worker-replace-event-handler-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/workers/worker-replace-event-handler.html View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/workers/worker-replace-event-handler-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look (but no particular rush about this one.) i.e., depends on https://codereview.chromium.org/139263008/ ...
6 years, 11 months ago (2014-01-16 09:53:44 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-17 12:34:10 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years, 11 months ago (2014-01-19 10:41:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/140723002/1
6 years, 11 months ago (2014-01-20 16:31:22 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=23290
6 years, 11 months ago (2014-01-20 17:27:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/140723002/1
6 years, 11 months ago (2014-01-20 18:40:30 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=23304
6 years, 11 months ago (2014-01-20 19:26:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/140723002/1
6 years, 11 months ago (2014-01-21 06:59:34 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 07:35:44 UTC) #9
Message was sent while issue was closed. 
Change committed as 165439

Powered by Google App Engine
This is Rietveld 408576698