Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1407203004: Parse outline shorthand in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse outline shorthand in CSSPropertyParser with CSSParserTokens Move outline shorthand property handling from LegacyCSSPropertyParser into CSSPropertyParser. Also move its related longhands. BUG=499780 Committed: https://crrev.com/8492c243f8e8ecbcccc8f41db14fe0a6d594f9ff Cr-Commit-Position: refs/heads/master@{#358606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 5 chunks +4 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rwlbuis
PTAL. This is the patch that was reverted earlier this week, but it should be ...
5 years, 1 month ago (2015-11-08 23:35:31 UTC) #3
Timothy Loh
On 2015/11/08 23:35:31, rwlbuis wrote: > PTAL. This is the patch that was reverted earlier ...
5 years, 1 month ago (2015-11-09 16:48:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407203004/1
5 years, 1 month ago (2015-11-09 17:03:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 18:07:09 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 18:08:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8492c243f8e8ecbcccc8f41db14fe0a6d594f9ff
Cr-Commit-Position: refs/heads/master@{#358606}

Powered by Google App Engine
This is Rietveld 408576698