Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1407203003: Re-enable PhishingClassifierTest and friends. (Closed)

Created:
5 years, 1 month ago by Jialiu Lin
Modified:
5 years, 1 month ago
Reviewers:
erikchen
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, Nathan Parker
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable PhishingClassifierTest and friends. We are pretty sure problem was fixed by https://codereview.chromium.org/1414603003/ BUG=542521 Committed: https://crrev.com/c83a627a60c2eeb41e65544bf35e64b91415701b Cr-Commit-Position: refs/heads/master@{#357168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jialiu Lin
erikchen, I'm re-enable these tests since you're confident the bug is fixed.
5 years, 1 month ago (2015-10-30 18:48:01 UTC) #3
erikchen
lgtm
5 years, 1 month ago (2015-10-30 18:48:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407203003/1
5 years, 1 month ago (2015-10-30 18:52:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 19:21:44 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 19:22:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c83a627a60c2eeb41e65544bf35e64b91415701b
Cr-Commit-Position: refs/heads/master@{#357168}

Powered by Google App Engine
This is Rietveld 408576698