Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1407193009: add command line cpu info to allow android neon test (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

add command line cpu info to allow android neon test in order to compare C and Neon code, a new command line flag is added. historically environment variables controlled cpu features, but on android apk it is easier to pass a command line option to disable cpu optimizations. R=harryjin@google.com BUG=libyuv:516 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/c629cb3afedfbd8c88c92891b5b843db2ad9aba2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -169 lines) Patch
M unit_test/color_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M unit_test/compare_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M unit_test/convert_test.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M unit_test/cpu_test.cc View 1 chunk +10 lines, -1 line 0 comments Download
M unit_test/planar_test.cc View 34 chunks +144 lines, -81 lines 0 comments Download
M unit_test/rotate_argb_test.cc View 4 chunks +47 lines, -23 lines 0 comments Download
M unit_test/rotate_test.cc View 5 chunks +46 lines, -24 lines 0 comments Download
M unit_test/scale_argb_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M unit_test/scale_test.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M unit_test/unit_test.h View 6 chunks +6 lines, -0 lines 0 comments Download
M unit_test/unit_test.cc View 13 chunks +50 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fbarchard1
5 years, 1 month ago (2015-11-04 00:45:12 UTC) #1
harryjin
lgtm
5 years, 1 month ago (2015-11-04 00:47:01 UTC) #2
fbarchard1
5 years, 1 month ago (2015-11-04 01:01:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c629cb3afedfbd8c88c92891b5b843db2ad9aba2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698