third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h - Issue 1407183002: Rename ShadowRootType::OpenByDefault to ShadowRootType::V0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

Issue 1407183002: Rename ShadowRootType::OpenByDefault to ShadowRootType::V0. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v1-attach-shadow

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp ('k') | third_party/WebKit/Source/core/editing/EditingTestBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

index a3f45777c0eb04da3f2b50902d37d4e0cd9729ef..5748962990ed6e9ff92ea5cab4f35080b8601463 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

@@ -46,7 +46,7 @@ class StyleSheetList;

enum class ShadowRootType {

UserAgent,

- OpenByDefault,

+ V0,

Open,

Closed

};

@@ -78,7 +78,7 @@ public:

ShadowRoot* youngerShadowRoot() const { return prev(); }

ShadowRoot* olderShadowRootForBindings() const;

- bool isOpen() const { return type() == ShadowRootType::OpenByDefault || type() == ShadowRootType::Open; }

+ bool isOpen() const { return type() == ShadowRootType::V0 || type() == ShadowRootType::Open; }

bool isYoungest() const { return !youngerShadowRoot(); }

bool isOldest() const { return !olderShadowRoot(); }