Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1407173005: Revert of OOPIF: Route keyboard events to focused frame in the browser process. (Closed)

Created:
5 years, 1 month ago by perkj_chrome
Modified:
5 years, 1 month ago
Reviewers:
kenrb, Charlie Reis, alexmos
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-page
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of OOPIF: Route keyboard events to focused frame in the browser process. (patchset #11 id:200001 of https://codereview.chromium.org/1405293002/ ) Reason for revert: SitePerProcessBrowserTest.SubframeKeyboardEventRouting is flaky on Windows 7. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SitePerProcessBrowserTest.SubframeKeyboardEventRouting http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/43548/steps/content_browsertests/logs/stdio Original issue's description: > OOPIF: Route keyboard events to focused frame in the browser process. > > Previously, keyboard events were always routed to the top frame's > RenderWidgetHost. With OOPIF, the top frame then forwarded the event > to an appropriate subframe renderer if needed. The extra hop is > inefficient and leaks information; moreover, the forwarding broke when > mouse event hit-testing in the browser process was introduced. > > This CL adds logic to send keyboard events directly to the right > RenderWidgetHost in the browser process, using the currently focused > frame which is already tracked in each FrameTree. This should be > supported for Aura, Mac, and Android. > > BUG=530663, 339659 > > Committed: https://crrev.com/e2a1799925ea027bd71ea9367280ddfb4403987a > Cr-Commit-Position: refs/heads/master@{#357011} TBR=kenrb@chromium.org,creis@chromium.org,alexmos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=false BUG=530663, 339659 Committed: https://crrev.com/8d3be002af4236d2a3cbd9f7687c78f275dcc2f1 Cr-Commit-Position: refs/heads/master@{#357086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -138 lines) Patch
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +2 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +8 lines, -22 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 4 chunks +10 lines, -59 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/test/data/page_with_input_field.html View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_chrome
Created Revert of OOPIF: Route keyboard events to focused frame in the browser process.
5 years, 1 month ago (2015-10-30 11:24:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407173005/1
5 years, 1 month ago (2015-10-30 11:25:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 12:40:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d3be002af4236d2a3cbd9f7687c78f275dcc2f1 Cr-Commit-Position: refs/heads/master@{#357086}
5 years, 1 month ago (2015-10-30 12:41:16 UTC) #6
alexmos
5 years, 1 month ago (2015-11-05 19:02:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1413123009/ by alexmos@chromium.org.

The reason for reverting is: The flakiness in
SitePerProcessBrowserTest.SubframeKeyboardEventRouting should now be fixed.  I
suspect the issue was that without knowing which remote frame was focused, the
page was setting the main frame as focused frame when the whole window
lost/gained focus (e.g., via alt-tab).  With
https://codereview.chromium.org/1423053002/, we now know propagate which remote
frames are focused, so this shouldn't happen anymore..

Powered by Google App Engine
This is Rietveld 408576698