|
|
DescriptionRoll ANGLE a5f64de..5b58cae
https://chromium.googlesource.com/angle/angle.git/+log/a5f64de..5b58cae
BUG=504872, 509883, 541551
TEST=bots
Committed: https://crrev.com/22c8fb80f8242c0eaf0c49bf23b5ffa96f6929a3
Cr-Commit-Position: refs/heads/master@{#358149}
Patch Set 1 #Messages
Total messages: 18 (7 generated)
Description was changed from ========== Roll ANGLE a5f64de..5b58cae https://chromium.googlesource.com/angle/angle.git/+log/a5f64de..5b58cae BUG=504872,509883,541551 TEST=bots ========== to ========== Roll ANGLE a5f64de..5b58cae https://chromium.googlesource.com/angle/angle.git/+log/a5f64de..5b58cae BUG=504872,509883,541551 TEST=bots ==========
cwallez@chromium.org changed reviewers: + jmadill@chromium.org
LGTM if bots are good (and clang bot compiles)
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407163009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407163009/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407163009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407163009/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2015/11/05 21:17:02, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) It didn't fail compilation last time, so I think it not related.
On 2015/11/05 21:17:02, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) It didn't fail compilation last time, so I think it not related.
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407163009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407163009/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/22c8fb80f8242c0eaf0c49bf23b5ffa96f6929a3 Cr-Commit-Position: refs/heads/master@{#358149}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1427653009/ by nasko@chromium.org. The reason for reverting is: This is breaking compilation on the bots: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8034 FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_unittests/DynamicHLSL_unittest.obj.rsp /c ../../third_party/angle/src/libANGLE/renderer/d3d/DynamicHLSL_unittest.cpp /Foobj/third_party/angle/src/tests/angle_unittests/DynamicHLSL_unittest.obj /Fdobj/third_party/angle/src/tests/angle_unittests_cc.pdb e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(43) :error C2146: syntax error : missing ';' before identifier 'DXGISwapChain' e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(43) :error C4430: missing type specifier - int assumed. Note: C++ does not support default-int e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(44) :error C2146: syntax error : missing ';' before identifier 'DXGIFactory' e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(44) :error C4430: missing type specifier - int assumed. Note: C++ does not support default-int e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(60) :error C2061: syntax error : identifier 'ID3D11Device' ninja: build stopped: subcommand failed.. |