Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1407163009: Roll ANGLE a5f64de..5b58cae (Closed)

Created:
5 years, 1 month ago by cwallez
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE a5f64de..5b58cae https://chromium.googlesource.com/angle/angle.git/+log/a5f64de..5b58cae BUG=504872, 509883, 541551 TEST=bots Committed: https://crrev.com/22c8fb80f8242c0eaf0c49bf23b5ffa96f6929a3 Cr-Commit-Position: refs/heads/master@{#358149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Jamie Madill
LGTM if bots are good (and clang bot compiles)
5 years, 1 month ago (2015-11-05 20:05:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407163009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407163009/1
5 years, 1 month ago (2015-11-05 20:26:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/136717)
5 years, 1 month ago (2015-11-05 20:38:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407163009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407163009/1
5 years, 1 month ago (2015-11-05 20:50:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/136758)
5 years, 1 month ago (2015-11-05 21:17:02 UTC) #11
Corentin Wallez
On 2015/11/05 21:17:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-05 21:26:33 UTC) #12
Corentin Wallez
On 2015/11/05 21:17:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-05 21:26:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407163009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407163009/1
5 years, 1 month ago (2015-11-05 21:27:25 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 22:28:44 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22c8fb80f8242c0eaf0c49bf23b5ffa96f6929a3 Cr-Commit-Position: refs/heads/master@{#358149}
5 years, 1 month ago (2015-11-05 22:29:55 UTC) #17
nasko
5 years, 1 month ago (2015-11-05 23:43:20 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1427653009/ by nasko@chromium.org.

The reason for reverting is: This is breaking compilation on the bots:

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8034

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/angle/src/tests/angle_unittests/DynamicHLSL_unittest.obj.rsp /c
../../third_party/angle/src/libANGLE/renderer/d3d/DynamicHLSL_unittest.cpp
/Foobj/third_party/angle/src/tests/angle_unittests/DynamicHLSL_unittest.obj
/Fdobj/third_party/angle/src/tests/angle_unittests_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(43)
:error C2146: syntax error : missing ';' before identifier 'DXGISwapChain'
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(43)
:error C4430: missing type specifier - int assumed. Note: C++ does not support
default-int
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(44)
:error C2146: syntax error : missing ';' before identifier 'DXGIFactory'
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(44)
:error C4430: missing type specifier - int assumed. Note: C++ does not support
default-int
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(60)
:error C2061: syntax error : identifier 'ID3D11Device'
ninja: build stopped: subcommand failed..

Powered by Google App Engine
This is Rietveld 408576698