Add feature use counting for window.external.AddSearchProvider (Blink side).

chrome/renderer/external_extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/external_extension.h"
 
 #include "chrome/common/render_messages.h"
 #include "chrome/common/search_provider.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
@@ skipping 98 matching lines @@
   RenderView* render_view = GetRenderView();
   if (!render_view)
     return;
 
   WebLocalFrame* webframe = WebLocalFrame::frameForCurrentContext();
   if (!webframe)
     return;
 
   GURL osdd_url = GURL(webframe->document().url()).Resolve(osdd_string);
   if (!osdd_url.is_empty() && osdd_url.is_valid()) {
+    webframe->countFeatureUse(blink::WebFrame::ExternalAddSearchProvider);
     render_view->Send(new ChromeViewHostMsg_PageHasOSDD(
         render_view->GetRoutingID(), webframe->document().url(), osdd_url,
         search_provider::EXPLICIT_PROVIDER));
   }
 }
 
 // static
 void ExternalExtensionWrapper::IsSearchProviderInstalled(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   if (!args.Length() || !args[0]->IsString())
     return;
 
   v8::String::Utf8Value utf8name(args[0]);
   if (!utf8name.length())
     return;
 
   std::string name(*utf8name);
   RenderView* render_view = GetRenderView();
   if (!render_view)
     return;
 
   WebLocalFrame* webframe = WebLocalFrame::frameForCurrentContext();
   if (!webframe)
     return;
 
   search_provider::InstallState install = search_provider::DENIED;
   GURL inquiry_url = GURL(webframe->document().url()).Resolve(name);
   if (!inquiry_url.is_empty()) {
-      render_view->Send(new ChromeViewHostMsg_GetSearchProviderInstallState(
-          render_view->GetRoutingID(),
-          webframe->document().url(),
-          inquiry_url,
-          &install));
+    webframe->countFeatureUse(

[dcheng, 2015/10/17 01:15:21]

Why not just add a UMA in Chrome? It doesn't seem necessary to plumb this into
Blink?

[Evan Stade, 2015/10/18 03:26:10]

Jochen and other API owners wanted to follow the standard process for measuring
blink feature usage to determine whether we should deprecate. See
https://codereview.chromium.org/1403803003/

+        blink::WebFrame::ExternalIsSearchProviderInstalled);
+    render_view->Send(new ChromeViewHostMsg_GetSearchProviderInstallState(
+        render_view->GetRoutingID(), webframe->document().url(), inquiry_url,
+        &install));
   }
 
   if (install == search_provider::DENIED) {
     // FIXME: throw access denied exception.
     v8::Isolate* isolate = args.GetIsolate();
     isolate->ThrowException(v8::Exception::Error(v8::String::Empty(isolate)));
     return;
   }
   args.GetReturnValue().Set(static_cast<int32_t>(install));
 }
 
 v8::Extension* ExternalExtension::Get() {
   return new ExternalExtensionWrapper();
 }
 
 }  // namespace extensions_v8