Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1407143011: Update RecordReplaceDraw unit test (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Total comments: 2

Patch Set 3 : Update parameter name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -34 lines) Patch
M tests/RecordReplaceDrawTest.cpp View 1 2 3 chunks +25 lines, -34 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
5 years, 1 month ago (2015-11-03 21:05:49 UTC) #3
reed1
lgtm, but adding klein
5 years, 1 month ago (2015-11-03 21:06:53 UTC) #5
mtklein
lgtm https://codereview.chromium.org/1407143011/diff/20001/tests/RecordReplaceDrawTest.cpp File tests/RecordReplaceDrawTest.cpp (right): https://codereview.chromium.org/1407143011/diff/20001/tests/RecordReplaceDrawTest.cpp#newcode93 tests/RecordReplaceDrawTest.cpp:93: void test_replacements(skiatest::Reporter* r, GrContext* context, bool testReplace) { ...
5 years, 1 month ago (2015-11-03 21:09:08 UTC) #6
robertphillips
https://codereview.chromium.org/1407143011/diff/20001/tests/RecordReplaceDrawTest.cpp File tests/RecordReplaceDrawTest.cpp (right): https://codereview.chromium.org/1407143011/diff/20001/tests/RecordReplaceDrawTest.cpp#newcode93 tests/RecordReplaceDrawTest.cpp:93: void test_replacements(skiatest::Reporter* r, GrContext* context, bool testReplace) { On ...
5 years, 1 month ago (2015-11-03 21:26:44 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143011/40001
5 years, 1 month ago (2015-11-03 21:27:00 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 12:23:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143011/40001
5 years, 1 month ago (2015-11-04 12:24:37 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 12:31:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/07b41eb962fdb007f788fcd82e338d7aef126064

Powered by Google App Engine
This is Rietveld 408576698