Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2146)

Issue 1407143010: Revert of stack: Adjust Pre-M Android incorrect debuggerd addresses. (Closed)

Created:
5 years, 1 month ago by simonb (inactive)
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of stack: Adjust Pre-M Android incorrect debuggerd addresses. (patchset #8 id:140001 of https://codereview.chromium.org/1412223008/ ) Reason for revert: Breaks bot. Example: http://build.chromium.org/p/chromium.android/builders/Android%20Aura%20Tester%20%28dbg%29/builds/38 Original issue's description: > stack: Adjust Pre-M Android incorrect debuggerd addresses. > > Code location addresses printed by debuggerd in pre-M Android > are wrong where relocations are packed, because the libunwind > on these targets does not understand non-zero min vaddrs in > ELF LOAD segments. > > Fix by searching the APK staging directory for libraries with > packed relocations, and adjusting the tombstone data on pre- > processing so that code addresses printed for these libraries > by debuggerd are offset by the min vaddr of the library that was > included in the APK. > > This feature is hidden behind a new --packed-relocation-adjustments > flag, and defines a new --chrome-apk-dir flag that can be used > to indicate the location of the APK staging directory (defaults > to ../chrome_apk/ within the chrome-symbols-dir). > > Uses the 'Build fingerprint' in the tombstone file to try to > auto-detect whether packed relocation adjustment should be > applied (that is, if the target is running pre-M Android). > > BUG=536847 > > Committed: https://crrev.com/a0773c285a4a3a1a77df987a187d83096feb635f > Cr-Commit-Position: refs/heads/master@{#356858} TBR=andrewhayden@chromium.org,pasko@chromium.org,primiano@chromium.org,rmcilroy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536847 Committed: https://crrev.com/2d86a92b7095a803d2bcf6bb74804de50a2df42f Cr-Commit-Position: refs/heads/master@{#356870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -266 lines) Patch
M third_party/android_platform/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/android_platform/development/scripts/stack View 7 chunks +5 lines, -60 lines 0 comments Download
M third_party/android_platform/development/scripts/stack_core.py View 5 chunks +36 lines, -77 lines 0 comments Download
D third_party/android_platform/development/scripts/stack_libs.py View 1 chunk +0 lines, -125 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
simonb (inactive)
Created Revert of stack: Adjust Pre-M Android incorrect debuggerd addresses.
5 years, 1 month ago (2015-10-29 16:57:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143010/1
5 years, 1 month ago (2015-10-29 16:59:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407143010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407143010/1
5 years, 1 month ago (2015-10-29 17:03:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 17:04:44 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 17:05:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d86a92b7095a803d2bcf6bb74804de50a2df42f
Cr-Commit-Position: refs/heads/master@{#356870}

Powered by Google App Engine
This is Rietveld 408576698