Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 1407133017: Cleanup some dead code in blink::ImageBuffer and friends (Closed)

Created:
5 years, 1 month ago by Justin Novosad
Modified:
5 years, 1 month ago
CC:
chromium-reviews, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, Rik, blink-reviews-platform-graphics_chromium.org, dshwang, danakj, krit, f(malita), piman+watch_chromium.org, blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup some dead code in blink::ImageBuffer and friends The deprecatedBitmapForOverwrite() methods were still referenced but never being called. This CL cleans that up. BUG=551658 Committed: https://crrev.com/e0d003a62820bf5992f2e9ba9a0f10f3fff34576 Cr-Commit-Position: refs/heads/master@{#358558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -99 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBufferSurface.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 2 chunks +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 chunk +0 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (4 generated)
Justin Novosad
PTAL
5 years, 1 month ago (2015-11-04 22:32:44 UTC) #2
Justin Novosad
On 2015/11/04 22:32:44, Justin Novosad wrote: > PTAL The mac fail is flake: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Fscript-sync-slow-scripts-onerror.html
5 years, 1 month ago (2015-11-04 23:16:55 UTC) #3
Justin Novosad
5 years, 1 month ago (2015-11-05 18:17:05 UTC) #5
Tom Hudson
Wow, that's a lot more dead code than I thought you'd found; only nit is ...
5 years, 1 month ago (2015-11-05 20:08:55 UTC) #7
Justin Novosad
kbr@: Review ping! You are the only OWNER of both modules/webgl and platform/graphics
5 years, 1 month ago (2015-11-06 15:12:16 UTC) #8
bajones
On 2015/11/06 15:12:16, Justin Novosad wrote: > kbr@: Review ping! You are the only OWNER ...
5 years, 1 month ago (2015-11-07 20:19:31 UTC) #9
jbroman
junov: FYI, you are an owner of platform/graphics, so the review of that directory doesn't ...
5 years, 1 month ago (2015-11-07 21:21:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407133017/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407133017/1
5 years, 1 month ago (2015-11-08 21:54:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-08 23:12:57 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0d003a62820bf5992f2e9ba9a0f10f3fff34576 Cr-Commit-Position: refs/heads/master@{#358558}
5 years, 1 month ago (2015-11-08 23:13:40 UTC) #14
Ken Russell (switch to Gerrit)
5 years, 1 month ago (2015-11-10 03:21:37 UTC) #15
Message was sent while issue was closed.
Sorry for not being around to review this. LGTM after the fact, assuming this
code path really can no longer be taken.

Powered by Google App Engine
This is Rietveld 408576698