Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1407133008: chromeos: Remove implicit Point to PointF conversions. (Closed)

Created:
5 years, 2 months ago by danakj
Modified:
5 years, 2 months ago
Reviewers:
dmazzoni, Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org, piman, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Remove implicit Point to PointF conversions. The implicit conversion operator is going away. The code currently throws away the decimal part of event locations while passing them through the touch exploration controller from one event to another, this fixes some of those. R=dmazzoni@chromium.org BUG=342848 Committed: https://crrev.com/d29c68068138dde6f35da3fb7fc6adad40e97638 Cr-Commit-Position: refs/heads/master@{#355875}

Patch Set 1 : pointfconvert-chromeos: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -51 lines) Patch
M ui/chromeos/touch_exploration_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 11 chunks +33 lines, -50 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
danakj
5 years, 2 months ago (2015-10-21 00:04:04 UTC) #2
danakj
ping
5 years, 2 months ago (2015-10-22 21:28:31 UTC) #3
danakj
+derat PTAL dmazzoni appears to be unavailable
5 years, 2 months ago (2015-10-23 19:42:58 UTC) #5
Daniel Erat
lgtm
5 years, 2 months ago (2015-10-23 20:06:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407133008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407133008/20001
5 years, 2 months ago (2015-10-23 20:15:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-10-23 20:43:22 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d29c68068138dde6f35da3fb7fc6adad40e97638 Cr-Commit-Position: refs/heads/master@{#355875}
5 years, 2 months ago (2015-10-23 20:44:17 UTC) #10
dmazzoni
5 years, 2 months ago (2015-10-23 20:46:39 UTC) #11
Message was sent while issue was closed.
lgtm

Oops, sorry I missed this one! I saw all of the other "Remove implicit Point to
PointF conversions" in my inbox (that didn't require my approval) and
accidentally assumed this was one of those.

Powered by Google App Engine
This is Rietveld 408576698