Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1407123011: Use a converter to resolve style for -webkit-filter and backdrop-filter (Closed)

Created:
5 years, 1 month ago by fs
Modified:
5 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a converter to resolve style for -webkit-filter and backdrop-filter Gets rid of the custom builders with a simple refactor of the FilterOperationResolver. BUG=109224 Committed: https://crrev.com/4d1155c211001713c75d44616abcd6c7ab1afd92 Cr-Commit-Position: refs/heads/master@{#357540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -28 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 1 month ago (2015-11-02 19:11:18 UTC) #2
Timothy Loh
On 2015/11/02 19:11:18, fs wrote: lgtm
5 years, 1 month ago (2015-11-02 23:33:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407123011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407123011/1
5 years, 1 month ago (2015-11-03 08:45:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 09:36:48 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 09:37:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d1155c211001713c75d44616abcd6c7ab1afd92
Cr-Commit-Position: refs/heads/master@{#357540}

Powered by Google App Engine
This is Rietveld 408576698